NestedRecordUpdate: support multiline records #710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auduchinok
reviewed
Sep 18, 2024
| produceHighlighting fieldsChainMatch currentFieldBinding consumer | ||
|
|
||
| and startNewAnalyze recordExpr consumer = |
There was a problem hiding this comment.
It's difficult to understand what does the function do, from the startNewAnalyze name. Is there some other function that ends it? Analyze is not a noun, what does the name actually mean?
Could it be something simple, while descriptive, like analyzeRecordExpr?
auduchinok
reviewed
Sep 18, 2024
auduchinok
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: assignment expression still should be a single line